Skip to content

Fix service contracts import XML example #13580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix service contracts import XML example #13580

merged 1 commit into from
Apr 23, 2020

Conversation

7ochem
Copy link
Contributor

@7ochem 7ochem commented Apr 23, 2020

When the example for imports in service XML was extended in the 4.3 documentation, the defaults and the prototype were put inside the <imports> tag instead of a <services> tag.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 23, 2020
@javiereguiluz
Copy link
Member

Good catch, thanks Jochem.

@javiereguiluz javiereguiluz merged commit 29c03b6 into symfony:4.4 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@7ochem @javiereguiluz @carsonbot